[jdk9] (XS) RFR: 8165243: Base64.Encoder.wrap(os).write(byte[], int, int) with incorrect arguments should not produce output

Ivan Gerasimov ivan.gerasimov at oracle.com
Fri Sep 2 08:59:49 UTC 2016


Thank you Roger and Alan for review!


On 01.09.2016 20:39, Alan Bateman wrote:
> TestBase64 is the unit test for this API, should the test be added to 
> that instead?
>

Yes, it should be better.

http://cr.openjdk.java.net/~igerasim/8165243/01/webrev/

I also added another test case to make sure the decoder doesn't expose 
the same bug.
A cleanup pass was performed to make the code more compact.

Is it good to go?

With kind regards,
Ivan


More information about the core-libs-dev mailing list