RFR: 8151901: test/tools/pack200/Pack200Test fails on verifying native unpacked JAR

[John Rose]

> On Sep 2, 2016, at 10:14 AM, Kumar Srinivasan <kumar.x.srinivasan at oracle.com> wrote:
> 
> Hi John,
> 
> Please review the amended patch, based on our discussions.
> http://cr.openjdk.java.net/~ksrini/8151901/webrev.01/ <http://cr.openjdk.java.net/~ksrini/8151901/webrev.01/>
> 
> Highlights:
> * adjust the ordering of the InnerClass and BootStrapMethods computations
> * enabled the test, and disabled memory leak check, which causes intermittent
>   failures, because of GC's ergonomics etc.
> * added the two test files to golden.jar, just in case.
> 
> Thanks
> Kumar

Much better; I'm glad we figured it out.

This comment is wrong:
+        // remove the attr previously set, otherwise add the bsm and
+        // references as required
Should be merely:
+        // add the bsm and references as required

Reviewed!

— John