Review Request: JDK-8165563 ClassLoader::getSystemClassLoader will never be null

Mandy Chung mandy.chung at oracle.com
Wed Sep 7 21:10:55 UTC 2016


> On Sep 7, 2016, at 2:02 PM, Paul Sandoz <paul.sandoz at oracle.com> wrote:
> 
> 
>> On 7 Sep 2016, at 12:42, Mandy Chung <mandy.chung at oracle.com> wrote:
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165563/webrev.00/
>> 
> 
> +1
> 
> Do we have any tests that can be cleaned up? If so log a separate issue for that?

I did scan on the jdk/test and don’t see any test checking for null system class loader.  Some of them actually assume non-null.

On the other hand, there may be JDK classes that handle the null case and can be cleaned up.  I didn’t do the audit and plan to leave it for the component teams to follow up.

Mandy



More information about the core-libs-dev mailing list