RFR JDK-8165617: Cleanup whitespace in jaxp/test

[Joe Wang]

True, and it looks like there's a little gap between the normalizer tool 
and jcheck that I didn't know. The importance is that the source files 
shall not contain tabs, carriage returns, or trailing spaces. But as we 
found out in this case, the normalizer has an extra rule that is, there 
shall be one and only one empty line at the end of file. You're fine as 
long as you have jcheck[1] set up, but it's a good practice to keep only 
one empty line at the end of file.

[1] http://openjdk.java.net/projects/code-tools/jcheck/

Best,
Joe

On 9/8/16, 12:07 AM, Frank Yuan wrote:
> The normalizer tool will remove any extra LFs, only leave one. But it may be an internal tool, so I think it's not a rule.
>
> Thanks
> Frank
>
>> -----Original Message-----
>> From: Langer, Christoph [mailto:christoph.langer at sap.com]
>> Subject: RE: RFR JDK-8165617: Cleanup whitespace in jaxp/test
>>
>> Hi Frank,
>>
>> just out of interest: Is it a rule not to have any LFs at the end of java files?
>>
>> Best regards
>> Christoph
>>
>>> -----Original Message-----
>>> From: core-libs-dev [mailto:core-libs-dev-bounces at openjdk.java.net] On Behalf
>>> Of Frank Yuan
>>> Sent: Donnerstag, 8. September 2016 06:35
>>> To: 'Joe Wang'<huizhe.wang at oracle.com>
>>> Cc: 'core-libs-dev'<core-libs-dev at openjdk.java.net>
>>> Subject: RE: RFR JDK-8165617: Cleanup whitespace in jaxp/test
>>>
>>> Thank you! Pushed.
>>>
>>> Frank
>>>
>>> -----Original Message-----
>>> From: Joe Wang [mailto:huizhe.wang at oracle.com]
>>> Sent: Thursday, September 08, 2016 12:11 PM
>>> To: Frank Yuan
>>> Cc: 'core-libs-dev'
>>> Subject: Re: RFR JDK-8165617: Cleanup whitespace in jaxp/test
>>>
>>> Hi Frank,
>>>
>>> Looks good.  Thanks for getting this cleaned up!
>>>
>>> Best,
>>> Joe
>>>
>>> On 9/7/16, 8:33 PM, Frank Yuan wrote:
>>>> Hi
>>>>
>>>> This bug is to remove the extra LF from the end of the java files, that will help
>>> to conform with the normalizer.
>>>> Anyone would like to take a look?
>>> http://cr.openjdk.java.net/~fyuan/8165617/webrev.00/
>>>>
>>>> Thanks
>>>> Frank
>>>>
>