RFR 9: 8155760 Implement Serialization Filtering

Roger Riggs Roger.Riggs at Oracle.com
Fri Sep 9 14:55:57 UTC 2016


Hi Andrej,

Thanks for the review and comments..

On 9/9/2016 2:32 AM, Andrej Golovnin wrote:
> Hi Roger,
>
> src/java.base/share/classes/java/io/ObjectInputStream.java
>
> 259     private static class Logging {
>
> The class can be final.
But there is no advantage or limitation since it is an private 
implementation class.
>
> 1265                                 ?  Logger.Level.DEBUG
>
> There is one space too much before "Logger".
removed
>
> 2611         /** total bytes read from the stream */
> 2612         private int totalBytesRead = 0;
>
> I think the type of the field totalBytesRead must be long. In the
> #skip(long)-method you update it with a long value.
ok

I'll fix these before pushing.

Thanks, Roger

>
> Best regards,
> Andrej Golovnin



More information about the core-libs-dev mailing list