RFR: jsr166 jdk9 integration wave 10
Paul Sandoz
paul.sandoz at oracle.com
Mon Sep 12 16:15:29 UTC 2016
> On 10 Sep 2016, at 10:21, Martin Buchholz <martinrb at google.com> wrote:
>
>
> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/
>
+1
CountedCompleter
—
176 * setPendingCount(1); // not off by one !
CountedCompleterTest
—
1910 setPendingCount(1); // not off by one !
I cannot resist saying you have an off by one (letter) error :-)
> Mostly docs and tests.
>
> jsr166 CVS is now caught up with jdk9+135
>
> Paul, I think we need to update AtomicInteger for VarHandle#getAndAdd:
>
> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/miscellaneous/src/java.base/share/classes/java/util/concurrent/atomic/AtomicInteger.java.udiff.html
>
>
Oops, sorry about that, i missed ‘em.
Paul.
More information about the core-libs-dev
mailing list