RFR: 8165723: JarFile::isMultiRelease() method returns false when it should return true

Paul Sandoz paul.sandoz at oracle.com
Mon Sep 12 16:57:35 UTC 2016


> On 12 Sep 2016, at 08:10, Claes Redestad <claes.redestad at oracle.com> wrote:
> 
> On 2016-09-12 16:24, Alan Bateman wrote:
>> This looks okay.
> 
> Thanks for the review!
> 
>> For the MultiReleaseJarAPI test then you probably should use jdk.testlibrary.RandomFactory so that the seed is recorded in the output for when the test fails.
> 
> Done.
> 
>> Also in CreateMultiReleaseTestJars then it might be cleaner to have a separate method to add extra stuff to the JAR file - I think that would make the usages a bit easier to read.
> 
> I took a second look, realized CreateMultiReleaseTestJars::buildShortMultiReleaseJar is no longer being used by any test, and simplified things a bit accordingly:
> 
> http://cr.openjdk.java.net/~redestad/8165723/webrev.02/
> 

+1 (post review i see it is already committed).

Our optimisation to compress the “optoSft” data was premature, i guess we had an error in the initial data.

Paul.


More information about the core-libs-dev mailing list