RFR 8159126 Add test to validate DriverManager.println output when DriverManager is initially loaded

Lance Andersen lance.andersen at oracle.com
Mon Sep 12 18:24:32 UTC 2016


> On Sep 12, 2016, at 2:20 PM, Joe Wang <huizhe.wang at oracle.com> wrote:
> 
> 
> 
> On 9/12/16, 10:21 AM, Lance Andersen wrote:
>> 
>> Hi Joe,
>>> On Sep 12, 2016, at 1:17 PM, Joe Wang <huizhe.wang at oracle.com <mailto:huizhe.wang at oracle.com>> wrote:
>>> 
>>> Hi Lance,
>>> 
>>> Since this change adds a test only, I assume the issue was fixed in another bug, it would be good to add a link in JBS.
>> Yes I had planned to do that
> 
> Sounds good.
>>> 
>>> It seems the initialization log has changed, no longer prints the first 2 lines.
>> Not sure what you mean, the output can/will vary based on the drivers that are available at init time.  The only output guaranteed is what the test validates and that is not required by the spec, it is just available debug trace.
> 
> The report said (in "EXPECTED") that at initialization in 6u45, sun.jdbc.odbc.JdbcOdbcDriver is loaded.
Never believe what you read Joe :-)

> The spec stated that at initialization, it will load any drivers through the service mechanism or system property, but it seems it didn't say whether it'd load the default if all others are not found.
There is no such thing as a default JDBC driver
> 
> Is that a change? I ran the test, with 6u45, the returned drivers contain sun.jdbc.odbc.JdbcOdbcDriver, and with current build, it didn't. If it's changed, is it worth it to note in the test and comment in JBS?

That is the JDBC-ODBC driver which was never supported and we removed it from the JDK as it is not supported.  It was never a requirement of Java SE or JDBC to be there.  It predates type 4 JDBC drivers going back to 1996-1997 during the initial prototyping of JDBC (back to my Sybase days).


> 
> Best,
> Joe
>> 
>>> It might be worth it to add a note/comment in the JBS along with link to the original change.
>> 
>> Best
>> Lance
>>> 
>>> Best,
>>> Joe
>>> 
>>> On 9/12/16, 9:29 AM, Lance Andersen wrote:
>>>> Happy Monday,
>>>> 
>>>> This RFR is to add a test to validate that the DriverManager.println output is accessible  when DriverManager is first loaded.
>>>> 
>>>> The webrev can be found at: http://cr.openjdk.java.net/~lancea/8159126/webrev.00/<http://cr.openjdk.java.net/~lancea/8159126/webrev.00/> <http://cr.openjdk.java.net/%7Elancea/8159126/webrev.00/%3Chttp://cr.openjdk.java.net/%7Elancea/8159126/webrev.00/%3E>
>>>> 
>>>> 
>>>> Ran JPRT to sanity check across platforms
>>>> 
>>>> 
>>>> 
>>>> Best
>>>> Lance
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering
>>>> 1 Network Drive
>>>> Burlington, MA 01803
>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com><mailto:Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>>
>>>> 
>>>> 
>>>> 
>> 
>> <Mail Attachment.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering 
>> 1 Network Drive 
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>> 
>> 
>> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list