RFR: JDK-8134373: explore potential uses of convenience factories within the JDK
Jonathan Bluett-Duncan
jbluettduncan at gmail.com
Thu Sep 15 14:10:51 UTC 2016
Patrick, would you kindly line-wrap the TOCTOU comment in
http://cr.openjdk.java.net/~reinhapa/reviews/8134373/webrev.01/src/java.base/share/classes/java/nio/file/FileTreeIterator.java.cdiff.html
for me, so that each line has 80 characters or less (and maybe insert a `.`
at the end)?
Kind regards,
Jonathan
On 15 September 2016 at 15:06, Jonathan Bluett-Duncan <
jbluettduncan at gmail.com> wrote:
> Pavel,
>
>
>> 6. I couldn't find any evidence that `resolverFields` might contain
>> `null`.
>> Am I missing a javadoc or a line of code? Maybe we should talk to
>> java.time
>> folks to see if it's the case?
>>
>
> When I ran the tests for java.time, one of them failed because `null` was
> being passed to `resolverFields`, so I came the conclusion that it was
> unsafe to make a change there.
>
> Kind regards,
> Jonathan
>
>
More information about the core-libs-dev
mailing list