[8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() doesn't return true on ppc

[Hiroshi H Horii]

Hi Volker, and Sean,

Thank you for your comments and suggestion.

I and Gustavo created a webrev that includes Bits and ByteArrayAccess.

http://cr.openjdk.java.net/~gromero/8165231/02/

I believe there is no other similar methods in jdk.

Regards,
Hiroshi
-----------------------
Hiroshi Horii, Ph.D.
IBM Research - Tokyo




From:   Sean Coffey <sean.coffey at oracle.com>
To:     Volker Simonis <volker.simonis at gmail.com>
Cc:     "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>, Java 
Core Libs <core-libs-dev at openjdk.java.net>, Hiroshi H 
Horii/Japan/IBM at IBMJP, "ppc-aix-port-dev at openjdk.java.net" 
<ppc-aix-port-dev at openjdk.java.net>, Gustavo Bueno Romero 
<gromero at br.ibm.com>, "Doerr, Martin" <martin.doerr at sap.com>
Date:   09/13/2016 21:46
Subject:        Re: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() 
doesn't return true on ppc



Sounds good Volker. Good catch.

regards,
Sean.

On 13/09/2016 13:09, Volker Simonis wrote:
> Hi Sean,
>
> thanks a lot for the fast response. I've updated the bug entry as
> requested and will push the change - maybe with the following
> potential improvement:
>
> @Hiroshi: also maybe not that performance relevant, I think we should
> we also fix sun/security/provider/ByteArrayAccess.java which contains
> the same construct:
>
>      // Return whether this platform supports full speed int/long memory 
access
>      // at unaligned addresses.
>      // This code was copied from java.nio.Bits because there is no 
equivalent
>      // public API.
>      private static boolean unaligned() {
>          String arch = java.security.AccessController.doPrivileged
>              (new sun.security.action.GetPropertyAction("os.arch", ""));
>          return arch.equals("i386") || arch.equals("x86") || 
arch.equals("amd64")
>              || arch.equals("x86_64");
>      }
>
> Regards,
> Volker