RFR: 8165944 jar utility doesn't process more than one -C argument

Steve Drach steve.drach at oracle.com
Thu Sep 29 21:27:28 UTC 2016


We discovered that the last webrev subtly changed the behavior of jar tool with respect to the JDK 8 jar tool, so that was fixed, along with some more simplification, and additional test cases were added to demonstrate consistent behavior across releases.  Here is the newest webrev.  

http://cr.openjdk.java.net/~sdrach/8165944/webrev.06/ <http://cr.openjdk.java.net/~sdrach/8165944/webrev.06/>


> On Sep 27, 2016, at 12:31 PM, Steve Drach <steve.drach at oracle.com> wrote:
> 
> After a discussion with Paul Sandoz, I’ve simplified and, hopefully, thus clarified the changeset.  The new webrev is
> 
> http://cr.openjdk.java.net/~sdrach/8165944/webrev.01/ <http://cr.openjdk.java.net/~sdrach/8165944/webrev.01/>
> 
>> On Sep 26, 2016, at 12:31 PM, Steve Drach <steve.drach at oracle.com <mailto:steve.drach at oracle.com>> wrote:
>> 
>> Hi,
>> 
>> Please review these changes to the jar tool to fix a capability regression I introduced in an earlier revision.  The issue is that this
>> 
>> $ jar -cf test.jar -C test1 . -C test2 .
>> 
>> only puts the files under test1 in the jar and ignores the files under test2.  The DoubleCs test verified the problem and the solution.
>> 
>> issue: https://bugs.openjdk.java.net/browse/JDK-8165944 <https://bugs.openjdk.java.net/browse/JDK-8165944> <https://bugs.openjdk.java.net/browse/JDK-8165944 <https://bugs.openjdk.java.net/browse/JDK-8165944>>
>> webrev: http://cr.openjdk.java.net/~sdrach/8165944/webrev.00/ <http://cr.openjdk.java.net/~sdrach/8165944/webrev.00/> <http://cr.openjdk.java.net/~sdrach/8165944/webrev.00/ <http://cr.openjdk.java.net/~sdrach/8165944/webrev.00/>>
>> 
>> Thanks,
>> Steve
>> 
> 



More information about the core-libs-dev mailing list