RFR: 8166842: String.hashCode() has a non-benign data race

Martin Buchholz martinrb at google.com
Fri Sep 30 14:45:05 UTC 2016


On Thu, Sep 29, 2016 at 2:31 AM, Peter Levart <peter.levart at gmail.com>
wrote:

>
> I think that this is enough to apply the fix, thanks.
>

I think general concurent software hygiene considerations are enough to
commit this fix.  Don't re-read fields, especially ones that are involved
in a race!  Finding an actual bug is awesome, but it's not necessary to get
approval, at least from this reviewer!


More information about the core-libs-dev mailing list