[9] RFR 8177969: Faster FilePermission::implies by avoiding the use of Path::relativize

Sean Mullan sean.mullan at oracle.com
Fri Apr 7 20:48:25 UTC 2017


This fix looks good to me. However, I would suggest adding some 
additional comments to the body of the containsPath method explaining 
what it is doing so that it is easier to understand.

--Sean

On 4/7/17 10:50 AM, Weijun Wang wrote:
> Webrev updated at
>
>    http://cr.openjdk.java.net/~weijun/8177969/webrev.01/
>
> Changes since webrev.00 [1]
>
> 1. Copyright years.
>
> 2. Test fix. check() should include Windows drive tests like contains()
> does.
>
> Thanks
> Max
>
> [1]
> http://cr.openjdk.java.net/~weijun/8177969/webrev.01/interdiff.patch.html
>
> On 04/05/2017 10:13 PM, Roger Riggs wrote:
>> Hi Max,
>>
>> The code looks ok.
>>
>> How much faster does it make FilePermission compares?
>>
>> I assume if it is not accepted to be fixed in JDK 9, you will push it to
>> JDK 10.
>>
>> Roger
>>
>>
>> On 4/3/2017 11:30 AM, Weijun Wang wrote:
>>> http://cr.openjdk.java.net/~weijun/8177969/webrev.00/
>>>
>>> This new implementation of containsPath(Path,Path) uses the logic of
>>> Path::relativize without directly calling it, which is much faster now.
>>>
>>> Thanks
>>> Max
>>


More information about the core-libs-dev mailing list