JDK 9 RFR of JDK-8169971: tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java fails intermittently

Amy Lu amy.lu at oracle.com
Thu Apr 13 10:28:35 UTC 2017


Thank you for the comments!

Yes, let's just make it simple, let jtreg to do the final clean up.

Please review the updated webrev: 
http://cr.openjdk.java.net/~amlu/8169971/webrev.01/

(Tested on one win64 and one win32, loop run 500 times, all pass.)

Thanks,
Amy


On 4/13/17 3:16 AM, Chris Hegarty wrote:
>> On 12 Apr 2017, at 17:36, Paul Sandoz <paul.sandoz at oracle.com> wrote:
>> ..
>> Do you think it’s simpler just to let jtreg cleanup? There are a few Mr.Jar tests that clean up after themselves but i wonder if it’s just simpler to let jtreg do it? any thoughts on that?
> I added these test library utility methods. Some times you actually
> need to clean up, other times you can leave it to jtreg ( if the files
> are all within the working/scratch directory ). Jtreg has similar
> retry logic when deleting files on Windows.
>
> It is common to see tests cleanup after themselves, as the original
> author may have been running the test standalone, not in jtreg,
> but we're mostly past that now.
>
> In this particular case it may be ok to leave it to jtreg to do the
> clean up.
>
> -Chris.



More information about the core-libs-dev mailing list