JDK 9 test-only RFR of 8179247: java/util/zip/TestExtraTime.java: add some instrumentation which might illuminate the failure of 2016-09-14

Brian Burkhalter brian.burkhalter at oracle.com
Wed Apr 26 05:49:14 UTC 2017


Hi Amy,

The status of test.dir is a little vague to some of us right now. Your comments are appreciated.

Brian

On Apr 25, 2017, at 6:32 PM, Amy Lu <amy.lu at oracle.com> wrote:

> On 4/26/17 12:06 AM, Brian Burkhalter wrote:
>> Hi Amy,
>> 
>> I think test.dir is preferred in case the folder location is specified to the harness.
> 
> Yes, makes sense.
> 
> (I'm not a reviewer.)
> Thanks,
> Amy
>> 
>> 
>> Brian
>> 
>> On Apr 24, 2017, at 8:22 PM, Amy Lu <amy.lu at oracle.com> wrote:
>> 
>>> I noticed something else:
>>>  148         Path zpath = Paths.get(System.getProperty("test.dir", "."),
>>> 
>>>  272         Path zpath = Paths.get(System.getProperty("test.dir", "."),
>>> 
>>> Is it better to use "user.dir" instead of "test.dir" here?
>>> 
>>> Thanks,
>>> Amy
>>> 
>>> On 4/25/17 6:08 AM, Brian Burkhalter wrote:
>>>> This might not be enough or might be totally unnecessary but could prove useful.
>>>> 
>>>> https://bugs.openjdk.java.net/browse/JDK-8179247
>>>> http://cr.openjdk.java.net/~bpb/8179247/webrev.00/
>>>> 
>>>> Thanks,
>>>> 
>>>> Brian
>> 
> 



More information about the core-libs-dev mailing list