JDK 9 RFR: JDK-8177146 MethodHandles.Lookup::bind allows illegal protected access

[Ron Pressler]

Do you mean just in the class name or also the directory name?

Ron

On 26/04/2017 20:53, Vladimir Ivanov wrote:
> Ron,
>
> The fix looks good.
>
> One request: please, try to avoid bug ids in test names. It's much 
> easier to work with tests when they have meaningful names and there's 
> already @bug jtreg tag to refer to the fixed bug from the test.
>
> Best regards,
> Vladimir Ivanov
>
> On 4/26/17 7:50 PM, Ron Pressler wrote:
>> Hi.
>> Please review,
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8177146
>> Webrev:
>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8177146-bind-protected-method/webrev/ 
>>
>>
>>
>> -----
>>
>> The patch contains a few changes:
>>
>> 1. The method `getDirectMethodCommon`, was changed so that if narrowing
>> due to protected method access must be done, it will be done regardless
>> of the flag doRestrict.
>>
>> 2. The private method ` getDirectMethodNoRestrict` was renamed to `
>> getDirectMethodNoRestrictInvokeSpecial`.
>>
>> 3. The method `bind` was changed to throw the correct exception type,
>> IAException.
>>
>> 4. `restrictReceiver` was changed such that it never widens the receiver
>> type. This could happen when the receiver was a subclass of the caller
>> class, and triggered the assertion (this happened not only in calls to
>> `bind` but also to `findVirtual`).
>>
>> -----
>>
>> Thanks
>> Ron
>>
>>