RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

Igor Ignatyev igor.ignatyev at oracle.com
Fri Aug 11 23:05:34 UTC 2017


Hi Mandy,

thank you for your review.

although jdk.test.lib.compiler.CompilerUtils is easy to use, it introduces dependency on jdk.compiler module and currently FragmentMetaspaceSimple.java depends only on java.base module and I would prefer it remain so.

Thanks,
-- Igor


> On Aug 11, 2017, at 12:47 PM, mandy chung <mandy.chung at oracle.com> wrote:
> On 8/10/17 9:02 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html <http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html>
> hotspot/test/runtime/Metaspace/FragmentMetaspaceSimple.java
>   26  * @library /test/lib classes
>   27  * @build test.Empty
>   28  * @run driver ClassFileInstaller test.Empty
> 
> jdk.test.lib.compiler.CompilerUtils is easy to use. I would suggest
> to convert these implicit compile+copy steps into an explicit
> setup step to compile ${test.src}/test/Empty.java into 
> the destination directory.  It'd be easy to read and understand.
> 
> Bumping up jtreg version is fine.
> 
> Mandy 



More information about the core-libs-dev mailing list