RFR: 8186314: code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change

[Eric Guo]

Hi Vicente,

It looks good to me.

Regards,
Eric (Shihua Guo)

On 17/08/2017 04:47, Vicente Romero wrote:
> Hi,
>
> Please review the fix for issue [1]. The fix can be found at [2]. The 
> fix is minimal, reproduced below:
>
> --- old/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/soap/MessageImpl.java	2017-08-16 16:31:21.403085344 -0400
> +++ new/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/soap/MessageImpl.java	2017-08-16 16:31:21.323085347 -0400
> @@ -890,7 +890,7 @@
>           needsSave();
>       }
>   
> -    static private final Iterator<AttachmentPart> nullIter = Collections.<AttachmentPart>EMPTY_LIST.iterator();
> +    static private final Iterator<AttachmentPart> nullIter = Collections.EMPTY_LIST.<AttachmentPart>iterator();
>   
>       @Override
>       public Iterator<AttachmentPart> getAttachments() {
>
> It doesn't imply any semantic change to the existing code. The reason 
> for the change is that the initialization expression was being 
> accepted by javac due to a bug in the parser. Once the bug gets fixed, 
> the old code will stop compiling.
>
> Thanks,
> Vicente
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8186314
> [2] http://cr.openjdk.java.net/~vromero/8186314/webrev.01/
>
> /Hello, />>>//>>>/Please review the fix to the following issue: />>>//>>>/https://bugs.openjdk.java.net/browse/JDK-8160199 />>>//>>>/The fix is located at: />>>//>>>/http://cr.openjdk.java.net/~naoto/8160199/webrev.03/ 
> <http://cr.openjdk.java.net/%7Enaoto/8160199/webrev.03/> />>>//>>>/The gist of the issue was that the script code has not been properly />>>/treated in macOS specific code. Since it shares the same code with />>>/other Unix, the locale format should follow POSIX, such as />>>/az-Cyrl-AZ needing to be az_AZ at Cyrl. 
> <http://mail.openjdk.java.net/mailman/listinfo/core-libs-dev> />>>//>>>/Naoto/