RFR [10]: 8185362: Replace use of AtomicReferenceFieldUpdater from BufferedInputStream with Unsafe

Claes Redestad claes.redestad at oracle.com
Mon Aug 21 15:09:52 UTC 2017


Hi Martin,

On 08/21/2017 04:33 PM, Martin Buchholz wrote:
> This comment still seems applicable. Can we move it into the docstring 
> for buf?
>
> We use nullness
> -     * of buf[] as primary indicator that this stream is closed. (The
> -     * "in" field is also nulled out on close.)
>

this is a reasonable request, the catch is that the field is protected 
and thus visible
in javadoc, so it needs to be updated as a CSR(?). Perhaps we can move 
it to a regular
comment associated with the field to avoid this implementation detail 
showing up in
javadocs?

http://cr.openjdk.java.net/~redestad/8185362/jdk.02/

Thanks!

/Claes


More information about the core-libs-dev mailing list