RFR: 8186334: JarFile throws ArrayIndexOutOfBoundsException when the manifest contains certain characters

[Claes Redestad]

On 2017-08-21 19:15, Paul Sandoz wrote:
>> On 21 Aug 2017, at 02:53, Claes Redestad <claes.redestad at oracle.com> wrote:
>>
>> Hi,
>>
>> this patch addresses an unfortunate regression where backtick characters
>> in a manifest can cause an AIOOBE.
>>
>> Webrev: http://cr.openjdk.java.net/~redestad/8186334/jdk.00/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8186334
>>
>> Basically an off-by-one issue during certain steps in the search algorithm,
>> meaning it is context dependent whether a backtick will trip on this issue
>> or not.
>>
> Ooops, looks good.

Thanks for reviewing!

>
> I see a workaround has been pushed to Jackson, which reduced my urge to suggest a nine respin. But… being slightly paranoid testing JarFile on a local maven central mirror would give us a better sense of the impact.

I think the 9 train has left the station even for issues of this 
severity. And seeing as there are somewhat straightforward workarounds I 
guess we'll have to live with my mistakes. Sorry!

/Claes