RFR: 8186500: StringConcatFactory.makeConcatWithConstants throws AssertionError when recipe contains non-String constants

[Aleksey Shipilev]

On 08/22/2017 07:10 PM, Claes Redestad wrote:
> On 2017-08-22 18:34, Aleksey Shipilev wrote:
>>> http://cr.openjdk.java.net/~redestad/8186500/jdk.01/
>> Still think testing for {null, Class, MethodHandle, MethodType} would cover more interesting corner
>> cases.
> 
> Do you mean as constant arguments? And what should happen in each of these cases?

As Remi says, should be equivalent to String.valueOf().

null: should be converted to "null"
{Class, MH, MT}: should be equivalent to Class::toString

My concern is that we have to check the new code, e.g. Wrapper.* does not barf when we pass
something non-primitive, non-String there.

Thanks,
-Aleksey