ISO-8859-16 charset/decoder/encoder

Paul Sandoz paul.sandoz at oracle.com
Fri Aug 25 16:19:53 UTC 2017


Hi Charlie,

Not sure how much you know already so just in case…

See here:

  http://openjdk.java.net/guide/producingChangeset.html <http://openjdk.java.net/guide/producingChangeset.html>

I am guessing you have an ssh key to access http://cr.openjdk.java.net/~headius/ <http://cr.openjdk.java.net/~headius/>

The first thing to do is produce a patch. If it’s small you can send it inline in email. Otherwise if larger create a webrev [1] and upload it to http://cr.openjdk.java.net/~headius/ <http://cr.openjdk.java.net/~headius/> and send a link in the email.

You should be able to run tests locally with jtreg [2].

One of us at Oracle can run it though a larger automated test suite on multiple platforms.

Then you will need a sponsor (to perhaps upload the webrev if necessary and) to commit the patch after review, i suggest someone knowledgable in the area should sponsor. Naoto, hint hint :-)

Hth,
Paul.

[1] http://openjdk.java.net/guide/webrevHelp.html <http://openjdk.java.net/guide/webrevHelp.html>
[2] http://openjdk.java.net/jtreg/ <http://openjdk.java.net/jtreg/> 

> On 24 Aug 2017, at 18:57, Charles Oliver Nutter <headius at headius.com> wrote:
> 
> Finally got around to opening an issue for this.
> https://bugs.openjdk.java.net/browse/JDK-8186751
> 
> I'm happy to do the requisite work to bring this patch to fruition, but
> since this is my first patch I'm not sure of the process.
> 
> - Charlie
> 
> On Fri, Nov 22, 2013 at 5:06 AM Charles Oliver Nutter <headius at headius.com>
> wrote:
> 
>> Again, apologies if this is not the right list.
>> 
>> OpenJDK does not currently contain support for encoding/decoding
>> ISO-8859-16. A JRuby user recently reported that they needed this
>> encoding. So, I implemented it.
>> 
>> Here's a link to the charset/decoder/encoder in JRuby's repository:
>> 
>> 
>> https://github.com/jruby/jruby/blob/master/core/src/main/java/org/jruby/util/encoding/ISO_8859_16.java
>> 
>> I tried to follow the general form of the other ISO-8859 charsets, but
>> there's probably more reuse possible (I believe they use sun.nio.cs
>> classes I can't access).
>> 
>> Happy to contribute this. Unsure of the process.
>> 
>> - Charlie
>> 
> -- 
> 
> - Charlie (mobile)



More information about the core-libs-dev mailing list