[10] RFR 8171049: Era.getDisplayName doesn't work with non-IsoChronology

Naoto Sato naoto.sato at oracle.com
Fri Aug 25 18:04:22 UTC 2017


Hi Stephen, thanks for the review.

On 8/25/17 10:49 AM, Stephen Colebourne wrote:
> The formatter should be  a static constant in both cases - no need to
> create each time.

Yes, that can be done.

> 
> I would have expected this to be done without using DateTimeFormatter
> however, just directly calling an internal API.

Which internal API?

Naoto

> 
> Stephen
> 
> 
> 
> 
> On 25 August 2017 at 18:43, Naoto Sato <naoto.sato at oracle.com> wrote:
>> Hi,
>>
>> Please review the fix to the following issue:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8171049
>>
>> The proposed fix is located at:
>>
>> http://cr.openjdk.java.net/~naoto/8171049/webrev.00/
>>
>> The fix is to implement Era.getDisplayName() in each Era enum.
>>
>> Naoto


More information about the core-libs-dev mailing list