RFR: JDK-8186924: Fix accessibility and other HTML issues in java.corba module

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Aug 31 22:03:25 UTC 2017


Thanks. I'll tweak the caption.

-- Jon

On 08/31/2017 02:45 PM, mandy chung wrote:
>
> On 8/29/17 11:42 AM, Jonathan Gibbons wrote:
>> Please review these mostly simple changes to address some 
>> accessibility and other minor HTML issues in the java.corba module.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8186924
>> Webrev: http://cr.openjdk.java.net/~jjg/8186924/webrev.00/
>> API: 
>> http://cr.openjdk.java.net/~jjg/8186924/api.00/java.corba-summary.html
>>
>> -- Jon
>>
>>
>> Notes on changes:
>>
>> src/java.corba/share/classes/org/omg/CORBA/ORB.java
>>     Update table for accessibility
>
> Not related to your change.  The colon in the caption looks strange 
> and perhaps should be taken out.  Well, java.corba is deprecated for 
> removal and might just leave it as is.
>
>   89  * <CAPTION>Standard Java CORBA Properties:</CAPTION>
>
>>
>> src/java.corba/share/classes/org/omg/CORBA/TCKind.java
>>     Fix broken HTML, by enclosing '.' in {@code} instead of <code>.
>
> Good catch.   This is hard to find through review.
>> src/java.corba/share/classes/org/omg/CORBA/doc-files/compliance.html
>>     Fix HTML5 errors, and set default language
>>
>> src/java.corba/share/classes/org/omg/CORBA/doc-files/generatedfiles.html
>>     Fix HTML5 errors, and set default language
>>
>> src/java.corba/share/classes/org/omg/PortableInterceptor/Interceptors.idl 
>>
>>     Fix two tables for accessibility, and remove duplicated text 
>> which was probably
>>     the result of a bad merge in times long ago. In the API, the 
>> modified classes
>>     are CloientRequestInfo and ServerRequestInfo.
>
> Otherwise, look fine to me.
> Mandy
>



More information about the core-libs-dev mailing list