[10] RFR: 8193507: [REDO] Startup regression due to JDK-8185582

Peter Levart peter.levart at gmail.com
Fri Dec 15 23:43:26 UTC 2017


Hi Claes,

I see this is already pushed. I don't have any additional comments, but 
just want to know what was wrong with old code. You say that you used 
non-static inner classes. I don't see that in old code. All the lambdas 
you replaced with nested static classes should have already captured 
just local variables. I must be missing something and I would really 
like to know what.

Regards, Peter

Claes Redestad je 14. 12. 2017 ob 12:07 napisal:
> Hi,
>
> my previous fix failed due to use of non-static inner classes which 
> kept the cleanable objects around. Also, Sherman suggested a more 
> thorough fix to Inflater/Deflater after I had already pushed.
>
> Webrev: http://cr.openjdk.java.net/~redestad/8193507/open.00/
>
> Verified all java/util/zip tests pass this time.
>
> /Claes
>
>



More information about the core-libs-dev mailing list