RFR: jsr166 jdk9 integration wave 14

[Martin Buchholz]

On Tue, Jan 31, 2017 at 4:03 PM, Paul Sandoz <paul.sandoz at oracle.com> wrote:

>
> On Tue, Jan 31, 2017 at 12:32 PM, Paul Sandoz <paul.sandoz at oracle.com>
> wrote:
>
>>
>> 1057     static final VarHandle ITEM;
>> 1058     static final VarHandle NEXT;
>>
>> Suggest a comment as to why they are package private, due to access via a
>> nested class. (Same in LinkedTransferQueue).
>>
>>
> package private is almost always used for nestmates in j.u.c.; a comment
> doesn't seem worthwhile.
>
>
>
> Ok, may i suggest renaming to NODE_ITEM and NODE_NEXT?
>

We prefer the shorter ITEM and NEXT, especially for nestmates where no
ambiguity is present.  There's a stronger case for your own  THREAD_PROBE,
although we might have happily stuck with PROBE.