RFR: JDK-8049375 - Extend how the org.omg.CORBA.ORB handles the search for orb.properties
Lance Andersen
lance.andersen at oracle.com
Mon Feb 6 23:47:01 UTC 2017
Hi Mark,
The change and test looks reasonable. I might consider removing the “TODO” comments from your test cases prior to pushing.
Maybe it is not needed, but should the test also be run with a SecurityManager or did you feel that was not needed?
HTH
Best
Lance
> On Feb 6, 2017, at 4:20 PM, Mark Sheppard <mark.sheppard at oracle.com> wrote:
>
> Hi,
> please oblige and review the following changes to the corba component
>
> http://cr.openjdk.java.net/~msheppar/8049375/corba/webrev/
> http://cr.openjdk.java.net/~msheppar/8049375/test/webrev/
>
> which address the issue
>
> https://bugs.openjdk.java.net/browse/JDK-8049375
>
> the JDK9 rt image has changed structure to include a conf directory.
> This will hold a component's properties file, if any, and as such the
> corba component has amended the locating of the properties file with
> a search in the ${java.home}/conf directory.
>
> regards
> Mark
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
More information about the core-libs-dev
mailing list