RFR [JAXP] JDK-8170192 Regression in XML Transform caused by JDK-8087303

Daniel Fuchs daniel.fuchs at oracle.com
Fri Feb 10 13:25:23 UTC 2017


Hi Frank,

Thanks for fixing this!

I imported your patch and played with it a bit.
Also ran the jaxp test.

Both issues reported have indeed disappeared.

So that's a +1 from me.

best regards,

-- daniel

On 10/02/17 11:03, Frank Yuan wrote:
> Hi All
>
>
>
> Would you like to review
> http://cr.openjdk.java.net/~fyuan/8174025/webrev.00/?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8174025
>
>
>
> JDK-8087303 introduced 2 issues:
>
> 1.       Flaw when xlst uses disable-output-escaping attribute
>
> 2.       Eat the whitespace between html inline elements
>
>
>
> This patch fixed the issues.
>
> To fix the second issue, we decide to keep the compatibility with JDK 8
> on the whitespace handling, that is only LSSerializer cleans the extra
> whitespaces in if pretty-print is on, but XSLT doesn’t.
>
> I modified the behavior of getIndent() method in class ToStream, to make
> LSSerializer be sensitive of current state from ToStream. This should be
> safe because ToStream is an internal class and getIndent() method is
> never used before.
>
>
>
> Thanks
>
> Frank
>
>
>



More information about the core-libs-dev mailing list