RFR: JDK-8173094, 8173751, 8173752, 8173755, 8173802

Abhijit Roy abhijit.r.roy at oracle.com
Mon Feb 13 18:37:30 UTC 2017


Hi Sean,

Yes, It would be great if you could push it for me. For that, I will 
send you a new webrev link with the below update.

Thanks,
Abhijit

On 2/13/2017 9:44 PM, Seán Coffey wrote:
> Updated the subject line. Looks fine.
>
> Minor nit with FilterOutputStream.java
>
>       * <code>write</code> method of its underlying output stream with 
> the single
>       * argument <code>b</code>.
>
> You're gone over 80 chars in length here. You can bring a word or two 
> down to the last line. Do you want me to push this change for you?
>
> Regards,
> Sean.
>
> On 10/02/17 19:18, Abhijit Roy wrote:
>
>> Hi Sean,
>>
>> As per your suggestion, I have corrected those points. Please find 
>> the link below for further review.
>>
>> http://cr.openjdk.java.net/~rpatil/ababroy/8173094/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Erpatil/ababroy/8173094/webrev.01/>
>>
>> Thanks,
>> Abhijit
>>
>>
>>
>> On 2/10/2017 10:37 PM, Seán Coffey wrote:
>>> Hi Abhijit,
>>>
>>> you'll need to correct the Copyright year format in your edits. It 
>>> needs to be "Copyright (c) <start_year>, <end_year>, Oracle..." format.
>>>
>>> For the ZipFile change, you need to use lower case 's' in @since.
>>>
>>> Looks good otherwise.
>>>
>>> regards,
>>> Sean.
>>>
>>> On 10/02/17 10:51, Abhijit Roy wrote:
>>>> Hi all,
>>>>
>>>> Please review the java doc fix for the below Bug:
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173094
>>>>
>>>> Description: Error in API documentation for SwingWorker
>>>>
>>>> Webrev-http://cr.openjdk.java.net/~rpatil/ababroy/8173094/webrev.00/
>>>>
>>>>
>>>> I have addressed some other doc issues which I included into the 
>>>> same webrev, please find those links below.
>>>>
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173751
>>>>
>>>> Description: Syntax error in ZipFile.getComment() method
>>>>
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173752
>>>>
>>>> Description: Syntax error in ZipEntry.setCompressedSize(long) 
>>>> method documentation
>>>>
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173755
>>>>
>>>> Description: The word input should be replaced by output in 
>>>> FilterOutputStream.write(byte[],int,int) method documentation
>>>>
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173802
>>>>
>>>> Description: Incorrect argument name in 
>>>> java.io.FilterInputStream.read(byte[]) method documentation
>>>>
>>>>
>>>>
>>>> Regards,
>>>>
>>>> Abhijit
>>>
>>
>



More information about the core-libs-dev mailing list