RFR: 8174735 Update JAX-WS RI integration to latest version
Roman Grigoriadi
roman.grigoriadi at oracle.com
Wed Feb 15 12:42:22 UTC 2017
Hi Mandy,
On 02/14/2017 11:53 PM, Mandy Chung wrote:
>> On Feb 14, 2017, at 4:00 AM, Roman Grigoriadi <roman.grigoriadi at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8174735
>> Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/00/
>
> jaxws/src/jdk.xml.ws/share/classes/com/sun/tools/internal/ws/wscompile/WsimportTool.java
>
> - /** JAXWS module name. JAXWS dependency is mandatory in generated Java module. */
> - private static final String JAXWS_MODULE = "java.xml.ws";
> + /** JAXB module name. JAXB dependency is mandatory in generated Java module. */
> + private static final String JAXWS_PACKAGE = "java.xml.ws”;
this looks to be merge failure on our side, will fix it again.
>
> JAXWS_MODULE is the right name as we discussed in the last JAX-WS integration to jdk9. This change should be reverted and the upstream project should be fixed.
>
> + if ("-release".equals(opt) && 9 >= getVersion(javacOptions.get(i + 1))) {
thanks, will be fixed to --release
>
> javac supports `—-release` (double dashes, GNU long form style) but not the single dash option. Is this new option in wsimport and wsgen tools? It should probably be consistent with javac.
>
> You can run jdeps —-check java.base,java.xml option to double check if any remaining qualified exports to these modules.
>
> Otherwise looks okay.
>
> Mandy
>
More information about the core-libs-dev
mailing list