[9] RFR: 8173390: Investigate SymbolTable in SAXParser

Daniel Fuchs daniel.fuchs at oracle.com
Wed Feb 15 17:37:57 UTC 2017


Hi Aleksej,

In the test:

   75         Assert.assertNotEquals(symTable1, symTable2, "Symbol table 
refence is the same");

I guess you meant Assert.assertNotSame - if what you want to do
is compare references.
(+ there is a typo in the message: refence => reference)

best regards,

-- daniel

On 15/02/17 16:31, Aleks Efimov wrote:
> Hi,
>
> Please, help to review the change required by JAXWS-RI code [1]:
> SAXParser needs to reset internal SymbolTable to enable pooling of
> parsers in SAAJ-RI code. Latest version of JAXWS-RI code (that is
> currently under review [2]) doesn't provide a workaround to reset the
> symbol table (it was done to remove module dependency on Xerces internal
> classes). So the solution is to reset the SymbolTable during SAXParser
> reset. The webrev with the changes and simple test that reproduces
> SAAJ-RI behavior:
>     http://cr.openjdk.java.net/~aefimov/8173390/9/00/
>
> The fix was tested with all JDK/JCK (JAX[P|B|WS] related tests. No
> failures observed.
>
>
> Thank you,
> Aleksej
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8173390
> [2]
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-February/046386.html
>
>



More information about the core-libs-dev mailing list