RFR: JDK-8146299 - Disable rmic -Xnew
Mark Sheppard
mark.sheppard at oracle.com
Wed Feb 15 23:42:17 UTC 2017
oki doki ... np ... amendments have been made ... verification testing
in progress
regards
Mark
On 15/02/2017 18:57, Stuart Marks wrote:
>
>
> On 2/15/17 9:18 AM, Mandy Chung wrote:
>>> On Feb 15, 2017, at 6:21 AM, Mark Sheppard
>>> <mark.sheppard at oracle.com> wrote:
>>> please oblige and review the following change:
>>> http://cr.openjdk.java.net/~msheppar/8146299-II/webrev.03/
>>
>> For the test, can you move @ignore to the top after @test which makes
>> it easier to tell this test is ignored.
>
> Hi Mandy,
>
> When Mark sent this for a preliminary review internally I had asked
> him to move the @ignore tag after the @library tag. I was prompted to
> do this because, when jtreg is run without the -ignore:quiet tag, the
> result is
>
> TEST RESULT: Error. Parse Exception: `@library' must appear before
> first action tag
>
> and oddly enough, @ignore is an action tag. But it seems like all of
> our test runs specify -ignore:quiet, which accepts @ignore pretty much
> anywhere, and other tests that use @ignore pretty much place it
> anywhere. So it's pretty much useless to run jtreg with anything other
> than -ignore:quiet.
>
> Mark, I'd suggest following Mandy's advice to put @ignore right after
> @test, and to disregard what I had told you previously. Sorry for the
> confusion.
>
> s'marks
More information about the core-libs-dev
mailing list