Review Request: JDK-8174694: improve error message shown when main class can't be loaded

David Holmes david.holmes at oracle.com
Wed Feb 15 23:44:01 UTC 2017


On 16/02/2017 7:25 AM, Alan Bateman wrote:
> On 15/02/2017 20:41, Vicente Romero wrote:
>
>> Hi,
>>
>> Thanks guys for your comments. I have uploaded another iteration of
>> the review at [1],
>>
>> Vicente
>>
>> [1] http://cr.openjdk.java.net/~vromero/8174694/webrev.01/jdk.patch
>>
> I assume you use getClass + getMessage to avoid calling the exception's
> toString, is that right? The output looks good to me.

I find the distinction between ClassNotFoundException and 
NoClassdefFoundError to be troubling. Seems to me the real problem was 
not printing the full exception chain in the NCDFE case. This looks very 
ad-hoc and special-cased.

David

> -Alan


More information about the core-libs-dev mailing list