Review Request: jdeps --require and --check should detect the specified module in the image

Paul Sandoz paul.sandoz at oracle.com
Tue Jan 3 22:57:48 UTC 2017


> On 3 Jan 2017, at 14:55, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
>> On Jan 3, 2017, at 2:45 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>> 
>> 
>>> 
>>> 
>>> 154         // jdeps --module-path <modulepath> -m root paths
>>> 155         String cmd = String.format("jdeps --module-path %s --add-modules %s %s%n",
>>> 156             MODS_DIR, roots.stream().collect(Collectors.joining(",")),
>>> 157             Arrays.toString(paths));
>>> 
>>> Is the use of Arrays.toString correct here?
>>> 
>> 
>> Hmm..  why the test is passing with “[]” in the command line?  I will check that out.
> 
> It was correct since this string is used only for printing to the output.  The jdeps command is built programmatically in the test.
> 

Ok.


>> In any case, no need to modify this file.  I have reverted it.
>> 
> 
> Updated webrev:
> 
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8172212/webrev.01/
> 

+1

Paul.


More information about the core-libs-dev mailing list