Review Request: JDK-8172215 java launcher no longer accepts -cp "" empty string

Mandy Chung mandy.chung at oracle.com
Wed Jan 4 02:03:39 UTC 2017


> On Jan 3, 2017, at 5:23 PM, Paul Sandoz <paul.sandoz at oracle.com> wrote:
> 
> 
>> On 3 Jan 2017, at 15:59, Mandy Chung <mandy.chung at oracle.com> wrote:
>> 
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8172215/webrev.00/
>> 
>> This fixes the regression caused by JDK-8168836 such that java -cp “” would be accepted. It’s surprise that no launcher test covering such test case.  Now it’s added in JavaClassPathTest.
>> 
>> This patch also renames the testlibrary ModuleSourceBuilder to ModuleInfoMaker as Alan suggested.
>> 
> 
> 213     private static boolean isWindows = System.getProperty("os.name”)
> 
> Make it final and rename to IS_WINDOWS ?


Sure. Updated in place.

Mandy



More information about the core-libs-dev mailing list