RFR 8075884, new tests to check runtime usage with Multi-Release jars

[Paul Sandoz]

Hi Felix,

Generally looks good.

RuntimeTest
—

  78     @BeforeTest
  79     protected void setUpTest() throws Throwable {

Can you use @BeforeClass? since i believe the jar files only need to be created once for all tests.

(And i presume it just overwrites any existing files that were previously generated.)


 172         if (mainVersionActual != mainVersionExpected) {
 173             throw new AssertionError(
 174                     "Test failed: Expected Main class version: "
 175                             + mainVersionExpected + " Actual version: "
 176                             + mainVersionActual);
 177         }

You can use Assert.equals.


 191     @Test(dataProvider = "jarFiles")
 192     void testJjs(String jar, int mainVer, int helperVer, int resVer)
 193             throws Throwable {

What is the rational for testing with jjs? i.e. what does it test beyond the other tests?

Paul.


> On 5 Jan 2017, at 22:20, Felix Yang <felix.yang at oracle.com> wrote:
> 
> Hi there,
> 
>    please review the following new tests to check runtime usage with Multi-Release jars.
> 
> Bug:
> 
>    https://bugs.openjdk.java.net/browse/JDK-8075884
> 
> Webrev:
> 
>    http://cr.openjdk.java.net/~xiaofeya/8075884/webrev.00/
> 
> Thanks,
> 
> Felix
>