RFR: JDK-8172432,jar cleanup/update for module and mrm jar

[Mandy Chung]

> On Jan 10, 2017, at 12:25 AM, Xueming Shen <xueming.shen at oracle.com> wrote:
> 
> On 1/9/17, 5:39 PM, Mandy Chung wrote:
>> 
>>> On Jan 9, 2017, at 5:28 PM, Xueming Shen <xueming.shen at oracle.com> <mailto:xueming.shen at oracle.com> wrote:
>>> 
>>> http://cr.openjdk.java.net/~sherman/8172432/webrev/ <http://cr.openjdk.java.net/~sherman/8172432/webrev/>
>>> 
>>> the method has been updated as Paul suggested, to only take the root module-info.class
>>> and correct versioned   meta-inf/versions/n/module-info.class
>> Does it miss “/“ between n and module-info.class?  It reads to me it would return true if the name is "META-INF/versions/9module-info.class”?
> 
> good catch, the webrev has been updated to fix it #1882
> http://cr.openjdk.java.net/~sherman/8172432/webrev <http://cr.openjdk.java.net/~sherman/8172432/webrev>
> 

Looks good.

> I did try to come up with the test case to catch various "incorrect" versioned
> entries, but the Validator appears to be able to catch them, as the entries
> such as
> 
>            "META-INF/versions/module-info.class",
>           "META-INF/versions/9module-info.class",
> 
> basically are "illegal" versioned entries ....
> 
> The fix appears to work to not treat them as versioned module-info.class, as
> expected.
> 
> I will try to see if I can come up with a better way to test this corner case.

OK.  We can file a follow-up issue to add a test case, when you find a good way doing it.

Mandy