RFR: JDK-8172432,jar cleanup/update for module and mrm jar
Mandy Chung
mandy.chung at oracle.com
Fri Jan 13 00:42:47 UTC 2017
> On Jan 12, 2017, at 4:08 PM, Xueming Shen <xueming.shen at oracle.com> wrote:
>
> On 01/12/2017 03:44 PM, Mandy Chung wrote:
>>
>> http://cr.openjdk.java.net/~sherman/8172432/webrev.01 <http://cr.openjdk.java.net/%7Esherman/8172432/webrev.01>
>>
>> Validator.java
>> 159 if (entryName.endsWith(MODULE_INFO)) {
>>
>> Does this have the same issue as the isModuleInfoEntry method addresses (i.e. META-INF/versioned/n/module-info.class)?
>
> let's use the Main.isModuleInfoEntry for consistency.
> 159 // validate the versioned module-info
> 160 if (isModuleInfoEntry(entryName)) {
> 161 if (entryName.length() != MODULE_INFO.length())
> 162 checkModuleDescriptor(je);
> 163 return;
> 164 }
>
> webrev has been updated accordingly.
+1
Mandy
More information about the core-libs-dev
mailing list