8172971: java.management could use System.Logger

Mandy Chung mandy.chung at oracle.com
Thu Jan 19 19:07:11 UTC 2017


> On Jan 19, 2017, at 10:50 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Mandy,
> 
> Thanks for the review!
> 
> On 19/01/17 17:12, Mandy Chung wrote:
>> 
>> 
>> Is it intentional to change the level FINEST to DEBUG as opposed to TRACE in a couple places?  For example,
> 
> The regular mapping would be:
>  [CONFIG,FINE]  -> DEBUG,
>  [FINER,FINEST] -> TRACE.
> 
> There are a couple of places were unexpected exceptions where traced
> at level FINEST, and I arbitrarily decided that they should rather
> be traced with level DEBUG.
> 

That’s fine since there isn’t a very clear policy when to use FINEST and FINER anyway.

>> 
>> This test should have @modules java.logging and java.management.
> 
> OK - I believed @modules java.management should already be in TEST.ROOT
> I will double check.

If @modules is specified in a test, it will override the one in TEST.properties (I think that’s what you meant).  In any case, this test depends on java.logging.

Mandy


More information about the core-libs-dev mailing list