(JAXP) RFR: 8173111: Excessive recursion in EventFilterSupport when filtering over large number of XML events can cause StackOverflow
Lance Andersen
lance.andersen at oracle.com
Mon Jan 23 19:03:34 UTC 2017
Hi Daniel,
The changes look fine.
Did you give any consideration to using assertFalse in the smokeTest at line 73?
Probably want to consider a back port at some point to 8u when time permits.
Best
Lance
> On Jan 23, 2017, at 12:48 PM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>
> Hi,
>
> Please find below a fix for:
>
> 8173111: Excessive recursion in EventFilterSupport when filtering
> over large number of XML events can cause StackOverflow
> https://bugs.openjdk.java.net/browse/JDK-8173111
>
> The fix is almost trivial: it replaces a recursion by a loop in
> two places.
>
> http://cr.openjdk.java.net/~dfuchs/webrev_8173111/webrev.00/
>
> The test will fail without the fix (at least on my machine)
> and pass with it (on my machine and in our test system).
>
> best regards,
>
> -- daniel
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
More information about the core-libs-dev
mailing list