RFR of JDK-8171142: jdk_rmi registry test fail to clean up on failure

Hamlin Li huaming.li at oracle.com
Tue Jan 24 08:51:58 UTC 2017


Hi Roger, David,

Thank you for reviewing, modified as you suggested, and the code is pushed.

-Hamlin


On 2017/1/23 23:21, Roger Riggs wrote:
> Hi Hamlin,
>
> test/javax/rmi/PortableRemoteObject/ConcurrentHashMapTest.java:
>
>   line 130: trivial, but please add a space in "!=null"...
>
> Note: on Windows there is no difference between Process.destroy vs 
> Process.destroyForcibly,
> but on Linux it it is the difference between kill -15 and kill -9.
>
> Using destroyForcibly would be more certain as to the death of the 
> subprocess.
>
> Otherwise looks fine
>
> Thanks, Roger
>
>
> On 1/23/2017 1:38 AM, Hamlin Li wrote:
>> Would you please review the below patch?
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8171142
>>
>> webrev: http://cr.openjdk.java.net/~mli/8171142/webrev.00/
>>
>>
>> Thank you
>>
>> -Hamlin
>>
>>
>



More information about the core-libs-dev mailing list