RFR: 8167063: spurious message "A JNI error has occurred" if start-class cannot be initialized

[Alan Bateman]

On 25/01/2017 10:10, Ramanand Patil wrote:
> Hi Kumar,
> Thank you for the review and suggestions for the test case.
> Here is the updated Webrev: http://cr.openjdk.java.net/~rpatil/8167063/webrev.02/
>
I see Kumar is looking at the test, I'll stick with LauncherHelper.

The update to loadModuleMainClass looks okay now but I'm puzzled by the 
changes in loadMainClass. For starters  catching LinkageError and 
retrying the Class.forName looks fishy. I don't think you want that for 
errors like VerifyError or ClassFormatError.  In addition, it looks like 
the abort will now hide linkage errors where we used to get a helpful 
stack trace. I think what you are really need is to leave the original 
code was it was and just add a new catch block for LinkageError. Also 
java.launcher.cls.error1 or a new key cna be created so that the 
exception is printed (as it is done in loadModuleMainClass).

-Alan