RFR: 8172309: classpath wildcards code does not support --class-path

[Henry Jen]

> On Jan 26, 2017, at 4:09 PM, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
> 
> Henry,
> 
> You've changed old test cases into new test cases, thereby eliminating the old cases, which is not so good.
> 
> You should be adding new test cases, but changing old ones.
> 

I am not sure, I believe all wild-card cases still tested, just that we have different variety of calling -cp. Of course, it would be nice to test all cases with all 4 flavors of -cp, but I don’t think that’s necessary as I think the test coverage is the same.

Anyway, I could be wrong. If you feel strong about this, I can redo it. But that may takes more time to digest what the test cases are really for.

Cheers,
Henry


> -- Jon
> 
> 
> On 01/26/2017 02:31 PM, Kumar Srinivasan wrote:
>> 
>> Hi Henry,
>> 
>> Looks ok to me. Thanks for making this change.
>> 
>> Kumar
>> 
>>> Hi,
>>> 
>>> Please review the webrev[1], the fix is to ensure —class-path and —class-path= is processed correctly to expand wildcard. Changes are made in jdk repo. However, test case to verify the bug fix is in langtool repo.
>>> 
>>> Cheers,
>>> Henry
>>> 
>>> [1] http://cr.openjdk.java.net/~henryjen/jdk9/8172309/0/
>>> [2] https://bugs.openjdk.java.net/browse/JDK-8172309
>> 
>