RFR (JDK 10) 8172298: Reduce memory churn when linking VarHandles operations
Paul Sandoz
paul.sandoz at oracle.com
Mon Jan 30 19:48:46 UTC 2017
> On 30 Jan 2017, at 02:59, Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 01/28/2017 12:10 AM, Paul Sandoz wrote:
>> http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8172298-varhandle-link-reduce-memory/webrev/
>
> Looks good, but I think the StringBuilder is inefficiently sized: it adds
> (parameterCount() - 2) chars in the loop, skipping the first and and then two
> after the loop. So the total number of chars is exactly (prefix +
> parameterCount()), not +2?
>
Ah yes, now that the guard method type is used, which has 2 additional parameters types not included in the mangled method name. Fixed.
Thanks,
Paul.
More information about the core-libs-dev
mailing list