[10] 8177806: ldapContext.unbind not handling ldap entry with esc char

[Vyom Tewari]

Hi Rob,

Code change looks OK, below are few comments on test case.

1-> Remove System.exit(1) and throw Exception from main if test fails.

2-> Put srv.close() in finally block, in case of exception close will 
not be called.

3-> Do you need Thread.sleep(500) ?. I think it is not required.

4-> i will suggest you to use below  tag order.

/**
  * @test
  * @bug 8177806
  * @summary Test NameImpl escape character processing
  * @modules java.naming/javax.naming:open
  * @run main/othervm LdapEscapeTest
  */

Thanks,

Vyom


On Thursday 06 July 2017 04:14 AM, Rob McKenna wrote:
> Hi folks,
>
> Looking for a review for the following change.
>
> NameImpl.java is stripping escape characters unnecessarily:
>
> http://cr.openjdk.java.net/~robm/8177806/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8177806
>
> Thanks,
>
>      -Rob
>