JDK 10 RFR of JDK-8183377: Refactor java/lang/ClassLoader/deadlock shell tests to java

Weijun Wang weijun.wang at oracle.com
Fri Jul 14 08:26:55 UTC 2017


> On Jul 14, 2017, at 4:23 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
>> On Jul 13, 2017, at 5:14 PM, Amy Lu <amy.lu at oracle.com> wrote:
>> 
>> java/lang/ClassLoader/deadlock/TestCrossDelegate.sh
>> java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh
>> 
>> Please review this patch to refactor the shell tests to java.
>> 
>> bug: https://bugs.openjdk.java.net/browse/JDK-8183377
>> http://cr.openjdk.java.net/~amlu/8183377/webrev.00/
> 
> I suggest to use the scratch directory instead of user.dir so that the files will be cleaned up.

I haven’t reviewed the code but aren’t scratch and ${user.dir} the same thing?

--Max

> 
> An alternative to SetupLoader class would be use the testlibray CompileUtils to compile the classes in the specified destination. 
> 
> Mandy



More information about the core-libs-dev mailing list