[10] RFR: 8184603: Create ObjectStreamField signature lazily when possible
Aleksey Shipilev
shade at redhat.com
Fri Jul 14 13:25:54 UTC 2017
On 07/14/2017 02:47 PM, Claes Redestad wrote:
>> For extra points remove the superfluous null assignment of
>> `signature` and `field` ( as well as `offset` ).
>
> 'field' is final so that'd make javac cry bloody murder, but I fixed the
> rest and cleaned up a bit for consistency:
>
> http://cr.openjdk.java.net/~redestad/8184603/jdk.01/
Can you also not do $signature field "volatile", for the sake on non-x86
platforms? I think getSignature() has a benign race then, which is safe.
Thanks,
-Aleksey
More information about the core-libs-dev
mailing list