[10] RFR 8184706: Matcher doesn't indicate hitEnd after matching \u0D with \R at EOL

Ivan Gerasimov ivan.gerasimov at oracle.com
Sun Jul 16 04:27:30 UTC 2017


Thanks for review!


On 7/15/17 10:09 AM, Xueming Shen wrote:
> +1
>
> On 7/15/17, 1:41 AM, Ivan Gerasimov wrote:
>> Hello!
>>
>> It was spotted that in certain situations the Matcher.hitEnd() 
>> returns false, though the regexp engine in fact has hit the end of 
>> the input.
>> This is because the \R pattern can match both 0x0d and 0x0d0x0a 
>> sequences.  Thus, the engine "hits the end", if the input ends with 
>> 0x0d, since the engine wants to greedily consume 0x0a.
>>
>> Would you please help review the fix?
>>
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8184706
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8184706/00/webrev/
>>
>
>

-- 
With kind regards,
Ivan Gerasimov



More information about the core-libs-dev mailing list