JDK 10 RFR of JDK-8183377: Refactor java/lang/ClassLoader/deadlock shell tests to java

Mandy Chung mandy.chung at oracle.com
Mon Jul 24 17:15:23 UTC 2017


> On Jul 17, 2017, at 12:49 AM, Amy Lu <amy.lu at oracle.com> wrote:
> 
> On 7/14/17 4:41 PM, Mandy Chung wrote:
>> I think compiling the other classes to a destination explicitly to replace:
>>   29  * @build Alice Bob SupAlice SupBob
>>   30  * @run driver SetupLoader
>> 
>> will make the test clearer.  It’d be good to make that change.
> 
> Webrev updated: http://cr.openjdk.java.net/~amlu/8183377/webrev.01/

Looks good.  One minor suggestion is to place the source files under a directory showing its package hierachy e.g. src/comSA/Alice.java, src/comSB/Bob.java

No need for a new webrev.

thanks
Mandy



More information about the core-libs-dev mailing list