RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

Mandy Chung mandy.chung at oracle.com
Tue Jul 25 23:12:35 UTC 2017


> On Jul 21, 2017, at 6:35 PM, Andrey Nazarov <andrey.x.nazarov at oracle.com> wrote:
> 
> Hi,
> 
> Please review changes in launcher tests. I’ve added absent @modules jtreg tags.
> 
> Review: http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/ <http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/>

A few tests only require java.compiler but not jdk.compiler.  Maybe TestHelper should be updated to use java.util.spi.ToolProvider to find “javac” to avoid the dependency to java.compiler if no compiler is needed.

test/tools/launcher/modules/upgrademodulepath/UpgradeModulePathTest.java
  - can you keep @modules list in alphabetical order.

Mandy


More information about the core-libs-dev mailing list